Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable grpc server reflection for all interfaces #132

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

lukasmittag
Copy link
Contributor

This enables the grpc reflection for all interfaces.

@lukasmittag lukasmittag requested a review from rafaeling February 3, 2025 12:57
Copy link

codecov bot commented Feb 3, 2025

Codecov Report

Attention: Patch coverage is 45.45455% with 6 lines in your changes missing coverage. Please review.

Project coverage is 60.15%. Comparing base (6459879) to head (2948686).

Files with missing lines Patch % Lines
databroker/src/grpc/server.rs 45.45% 6 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #132   +/-   ##
=======================================
  Coverage   60.14%   60.15%           
=======================================
  Files          33       33           
  Lines       16191    16197    +6     
=======================================
+ Hits         9738     9743    +5     
- Misses       6453     6454    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@rafaeling rafaeling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, have you tested a bit with grpcurl?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants